Skip to content

[std] Avoid hanging paragraphs by introducing "General" subclauses #6977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

[std] Avoid hanging paragraphs by introducing "General" subclauses #6977

merged 1 commit into from
Jul 9, 2024

Conversation

jensmaurer
Copy link
Member

Fixes ISO/CS comment (C++23 proof)

Fixes #6975

@jensmaurer jensmaurer added the ballot-comment Response to an NB or ISO comment on a ballot label May 13, 2024
@jensmaurer jensmaurer changed the title [std] Avoid hanging paragraphs by introducing General subclauses [std] Avoid hanging paragraphs by introducing "General" subclauses May 13, 2024
@tkoeppe
Copy link
Contributor

tkoeppe commented May 13, 2024

Ahh, so the point of contention are the cases where we have "paragraph-less synopses" only? And I take it that's hard to check automatically?

@tkoeppe tkoeppe self-requested a review May 13, 2024 17:07
jwakely
jwakely reviewed May 13, 2024
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked whether there are any cross references to the parent which should be adjusted to refer to the new .general subclause?

We've previously broken a large number of refs that way.

jwakely
jwakely approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked there are no affected cross-references.

@jensmaurer jensmaurer added this to the C++23 milestone May 15, 2024
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 9, 2024

Thank you!

@tkoeppe tkoeppe merged commit 868b0b2 into cplusplus:main Jul 9, 2024
@jensmaurer jensmaurer deleted the e01 branch July 9, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@tkoeppe tkoeppe tkoeppe approved these changes

Assignees

@tkoeppe tkoeppe

Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Milestone
C++23
Development

Successfully merging this pull request may close these issues.

[ISO/CS C++2023] Remove hanging paragraphs
3 participants
@jensmaurer @tkoeppe @jwakely